ensure non-null project for domain and property descriptors #6971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-adam
approved these changes
Aug 29, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes non-null database constraint violations for the project field in DomainDescriptor and PropertyDescriptor classes, and improves error handling in the DataViewsPanel UI.
- Modified
getProject()methods to return the container itself when no project is available, ensuring the project field is never null - Enhanced error message display in DataViewsPanel to show specific exception details instead of generic "Failure" messages
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PropertyDescriptor.java | Updated getProject() to fallback to container when project is null |
| DomainDescriptor.java | Updated getProject() to fallback to container when project is null |
| DataViewsPanel.js | Improved error handling with descriptive failure messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
tracking issue
For both
DomainDescriptorandPropertyDescriptorthe project field has a not null database constraint. Recent changes to stop holding ontoContainerinstances broke some of this when the container was root. This just restores the prior behavior and also updates the data views panel to show something more helpful than an empty dialog when errors like this occur.Related Pull Requests
Tasks 📍